Use Advanced Search to search the entire archive.
[jsr363-experts] Re: EDR
- From: Martin Desruisseaux <
>
- To:
- Subject: [jsr363-experts] Re: EDR
- Date: Sat, 13 Dec 2014 02:05:39 +0900
- Organization: Geomatys
Resending my previous email, since I don't think it goes though the list:
Hello Werner
Le 27/11/14 00:56, Werner Keil a écrit :
>
Please have a look at the Spec on Google Docs:
>
https://docs.google.com/document/d/12KhosAFriGCczBs6gwtJJDfg_QlANT92_lhxUWO2gCY
Sorry for being so late. I just had a look and the specification, and it
looks okay. I fixed some formatting but otherwise did not edited the
content. Below are my comments about the content:
Page 8 - Objective
The three last bullets at the bottom of the page (about concrete
classes) are not part of the specification, but rather of the reference
implementation. I suggest to either omit them, or insert a line before
them saying "/The reference implementation includes:/".
Page 9 - Aspirations
First bullet ("/Small or no runtime overhead compared with an
implementation not using Unit-API/") is not true: there is a huge
overhead in using arithmetic operations on Quantity compared to double
primitive type. I suggest to either remove that bullet, or explain that
it may be true only when using UnitConverter directly, not Quantity.
Page 12 - Online-shop
Paragraph contains "/decimal point number/" words. Do you mean
"/floating point number/", or maybe "/decimal number/"?
Page 12 - Internet of Things
Where the picture come from? Do we have the right to insert it in our
document (does the picture has a license)?
Could the /Medical & Healthcare/ and /Quantified Self/ use cases give
actual examples of units or quantities?
I wonder if the following sentence should be rephrased? In particular
starting with something else the "See", avoiding acronyms not defined in
the specification. I'm also do not quite understand what is a "connected
scale".
>
See a few personal health devices from “Smart Pill Boxes” (knowing the
>
dosage a patient needs based on their EHR) to connected scales, blood
>
pressure, heartbeat or sugar sensors.
Page 16 - code example
I don't think that Vector should implement Quantity. It could have
implemented Measurement if we had kept that interface, but not Quantity
if we understand it as a scalar measurement. I suggest to replace the
first line by:
public class Vector<Q extends Quantity> {
I have not yet finished. Will continue the review a little bit later...
Martin