Skip to main content

[jsr363-experts] RI (Code Coverage and PR #33)

  • From: Werner Keil < >
  • To: " " < >
  • Subject: [jsr363-experts] RI (Code Coverage and PR #33)
  • Date: Mon, 15 Feb 2016 10:59:59 +0100

Dear Experts,

I recently pushed the coverage of he API project to 70%. Given it only
consists of 6 measured classes, it wasn't that hard, but doing so for the
RI (and ideally SE port) could certainly use help by one or the other of
you.

Aside from that, a GitHub user suggested changing BaseUnit via a PR:
https://github.com/unitsofmeasurement/unit-ri/pull/33

We don't merge pull-requests from non EG members, but that doesn't mean the
change is not worth considering. I noticed and also mentioned in the PR
comment, that both JSR 275 (back then there was only an abstract base class
Unit) and the proposed JScience 5 draft (with a structure closer to JSR 363
e.g. PhysicsUnit and AbstractUnit have a similar purpose) return *null *in
this case.

Please review and ideally comment on
https://github.com/unitsofmeasurement/unit-ri/pull/33 where you got an
opinion on how to handle it.

Thanks and Regards,

Werner


[jsr363-experts] RI (Code Coverage and PR #33)

Werner Keil 02/15/2016
 
 
Close
loading
Please Confirm
Close